Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix npm push workflow #2569

Merged
merged 3 commits into from
Apr 19, 2022
Merged

ci: Fix npm push workflow #2569

merged 3 commits into from
Apr 19, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Apr 19, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@adchia
ci: Fix NPM Push with missing working-directory
254c9bc 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
bump files
cfd4434 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
bump files
cd8a5af 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #2569 (cd8a5af) into master (753bd88) will decrease coverage by 21.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2569       +/-   ##
===========================================
- Coverage   81.51%   59.53%   -21.99%     
===========================================
  Files         141      143        +2     
  Lines       11941    11887       -54     
===========================================
- Hits         9734     7077     -2657     
- Misses       2207     4810     +2603
Flag Coverage Δ
integrationtests ?
unittests 59.53% <ø> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
.../integration/online_store/test_universal_online.py 16.83% <0.00%> (-78.01%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.88% <0.00%> (-76.12%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-67.91%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 33.92% <0.00%> (-66.08%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 35.36% <0.00%> (-63.42%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753bd88...cd8a5af. Read the comment docs.

achals
achals reviewed Apr 19, 2022
View reviewed changes
infra/scripts/release/bump_file_versions.py
@@ -4,7 +4,7 @@
import sys

USAGE = f"Usage: python {sys.argv[0]} [--help] | current_semver_version new_semver_version]"
VERSIONS_TO_BUMP = 27
VERSIONS_TO_BUMP = 28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the packages.json file added to the list of files to bump?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it already was there but seemingly wasn't being triggered because the version didn't match the previous version? not sure. Running the script locally tells me there are 28 files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - okay stamping

achals
achals approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8a17041 into feast-dev:master Apr 19, 2022
adchia added a commit that referenced this pull request Apr 20, 2022
@adchia
ci: Fix npm push workflow (#2569)
20b704a 
* ci: Fix NPM Push with missing working-directory

Signed-off-by: Danny Chiao <danny@tecton.ai>

* bump files

Signed-off-by: Danny Chiao <danny@tecton.ai>

* bump files

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the fixNPMPush branch July 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adchia @codecov-commenter @feast-ci-bot @achals