Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix release process to also commit package.json from the web ui #2582

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Apr 20, 2022

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #2582 (82a6fb9) into master (ed2f979) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2582      +/-   ##
==========================================
- Coverage   82.35%   82.23%   -0.12%     
==========================================
  Files         154      154              
  Lines       12735    12735              
==========================================
- Hits        10488    10473      -15     
- Misses       2247     2262      +15     
Flag Coverage Δ
integrationtests 72.53% <ø> (-0.48%) ⬇️
unittests 59.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 96.42% <0.00%> (-0.90%) ⬇️
sdk/python/tests/conftest.py 84.13% <0.00%> (-0.69%) ⬇️
.../integration/online_store/test_universal_online.py 95.18% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2f979...82a6fb9. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit d120e9c into feast-dev:master Apr 20, 2022
adchia added a commit that referenced this pull request Apr 20, 2022
@adchia adchia linked an issue Apr 21, 2022 that may be closed by this pull request
14 tasks
@adchia adchia deleted the fixRelease branch July 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feast Web UI
4 participants