Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the Maven build #262

Merged
merged 5 commits into from
Oct 21, 2019
Merged

Clean up the Maven build #262

merged 5 commits into from
Oct 21, 2019

Commits on Oct 21, 2019

  1. Clean up the Maven build 

    Three main themes:

- Fix core module dependency on ingestion, so that Maven resolves it as
  an inter-project dep without requiring it to be installed to (local)
  repository and mucking with the version.

- Use dependencyManagement in parent POM for common dependencies and
  families -- version drift between modules on things like gRPC and
  Google Cloud deps will bring more pain in the long run than any short-
  term convenience of letting them differ between modules. This makes it
  easy to control that consistently.

- Avoid (re)defining properties in submodule POMs -- similar reasoning
  as dependencies: drift leads to suffering. If you build only a subset
  of modules at a time, resolved values may differ based on how Maven
  orders the build.

  Also avoid repeating things that inherit from the parent POM, like
  module groupId.
    @ches
    ches committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    aaaf997 View commit details
    Browse the repository at this point in the history

  2. Enable -Xlint warnings, fix trivial deprecations

    @ches
    ches committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    88b3fcd View commit details
    Browse the repository at this point in the history

  3. Make sdk/java a child module of the main build 

    Updating the protobuf/protoc version everywhere to what the SDK used,
because it requires new APIs.
    @ches
    ches committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    d4a318e View commit details
    Browse the repository at this point in the history

  4. Don't recompile protos when they haven't changed 

    Checks mtime versus target/ directory. Saves considerable build time.
    @ches
    ches committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    e97bf59 View commit details
    Browse the repository at this point in the history

  5. Remove unused dependencies 

    According to

    mvn dependency:analyze -DignoreNonCompile

and running tests.

Also added some undeclared direct dependencies, though not covering them
comprehensively yet.
    @ches
    ches committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    5e65a07 View commit details
    Browse the repository at this point in the history