Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make quickstart docs consistent and add Web UI to colab #2794

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Jun 14, 2022

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

Codecov Report

Merging #2794 (b5d3aa4) into master (6fec431) will decrease coverage by 20.78%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2794       +/-   ##
===========================================
- Coverage   80.49%   59.70%   -20.79%     
===========================================
  Files         173      173               
  Lines       15254    15254               
===========================================
- Hits        12278     9107     -3171     
- Misses       2976     6147     +3171     
Flag Coverage Δ
integrationtests ?
unittests 59.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.80% <0.00%> (-76.20%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 23.52% <0.00%> (-74.51%) ⬇️
.../integration/online_store/test_universal_online.py 17.43% <0.00%> (-73.03%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fec431...b5d3aa4. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 33141f8 into feast-dev:master Jun 14, 2022
@adchia adchia deleted the updateQuickstart branch July 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants