ci: New workflow to build wheels #2866

kevjumba · 2022-06-27T20:34:49Z

What this PR does / why we need it:
https://github.com/kevjumba/feast/runs/7087711627?check_suite_focus=true => Shows that this workflow works!

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

achals · 2022-06-27T20:36:10Z

.github/workflows/build_wheels.yml

+          path: ./wheelhouse/*.whl
+
+
+  build-python-sdk-macos-py310:


Why don't we move this into build-python-sdk? And have a single step?

achals · 2022-06-27T20:36:21Z

.github/workflows/build_wheels.yml

+          echo $VERSION_WITHOUT_PREFIX
+          echo $HIGHEST_SEMVER_TAG
+
+  build-python-sdk:


nit, build-python-wheel

kevjumba · 2022-06-27T20:43:13Z

still doesn't work fixing

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

codecov-commenter · 2022-06-27T21:16:59Z

Codecov Report

Merging #2866 (978ce22) into master (2f2b519) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
- Coverage   80.67%   80.62%   -0.06%     
==========================================
  Files         176      176              
  Lines       15671    15671              
==========================================
- Hits        12643    12634       -9     
- Misses       3028     3037       +9

Flag	Coverage Δ
integrationtests	`70.78% <ø> (-0.13%)`	⬇️
unittests	`59.34% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/tests/utils/online_read_write_test.py	`93.54% <0.00%> (-6.46%)`	⬇️
.../integration/online_store/test_online_retrieval.py	`96.84% <0.00%> (-3.16%)`	⬇️
sdk/python/feast/infra/online_stores/datastore.py	`87.96% <0.00%> (-1.39%)`	⬇️
...ython/feast/embedded_go/online_features_service.py	`89.39% <0.00%> (-0.76%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2b519...978ce22. Read the comment docs.

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

achals · 2022-06-27T22:39:53Z

.github/workflows/build_wheels.yml

+      - name: Build py310 wheel
+        if: matrix.os == 'macos-10.15'
+        run: |
+          python3 setup.py sdist bdist_wheel


You can remove this if you remove cp310-macosx_x86_64 from CIBW_SKIP

achals · 2022-06-27T22:40:13Z

.github/workflows/build_wheels.yml

+      - name: Build and install dependencies go dependencies for py310
+        if: matrix.os == 'macos-10.15'
+        run: |
+          pip install -U pip setuptools wheel twine
+          make install-protoc-dependencies
+          make install-go-proto-dependencies
+          make install-go-ci-dependencies
+          make build-ui


Same comment

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

.github/workflows/build_wheels.yml

.github/workflows/publish.yml

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

felixwang9817

/lgtm

feast-ci-bot · 2022-06-28T06:34:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba added 3 commits June 27, 2022 12:42

Add new build workflow

c245e20

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

b0256b9

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

609557a

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

feast-ci-bot added approved size/L labels Jun 27, 2022

achals reviewed Jun 27, 2022

View reviewed changes

kevjumba added 2 commits June 27, 2022 14:08

fix

090c7af

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

6ed11be

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba added 6 commits June 27, 2022 14:18

Fix

6d5d9a0

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

c3a55e5

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

5110ef9

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

d5a8f36

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

6be258d

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

4125536

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

achals reviewed Jun 27, 2022

View reviewed changes

kevjumba added 13 commits June 27, 2022 15:42

Fix

e829bbd

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

7fdda76

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

21d07d7

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

7a37d94

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

1a7033e

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

3ad9ce2

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

2730f96

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

1bb556f

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

8028bf9

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

fbada35

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

f16d464

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

58c5dda

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

485444f

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba added 2 commits June 27, 2022 21:57

Fix

20953f2

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

831359f

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

feast-ci-bot added size/XL and removed size/L labels Jun 28, 2022

kevjumba added 6 commits June 27, 2022 22:10

Fix

0a6c621

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

eb5aa24

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

5000966

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

e8dd17c

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Finally working version

8a8f994

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

0a6fffc

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

feast-ci-bot added size/L and removed size/XL labels Jun 28, 2022

Fix

1d9feab

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

felixwang9817 reviewed Jun 28, 2022

View reviewed changes

.github/workflows/build_wheels.yml Outdated Show resolved Hide resolved

.github/workflows/publish.yml Show resolved Hide resolved

.github/workflows/publish.yml Show resolved Hide resolved

Fix

978ce22

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

felixwang9817 approved these changes Jun 28, 2022

View reviewed changes

feast-ci-bot assigned felixwang9817 Jun 28, 2022

feast-ci-bot added the lgtm label Jun 28, 2022

felixwang9817 removed do-not-merge/work-in-progress lgtm labels Jun 28, 2022

kevjumba added the do-not-merge/work-in-progress label Jun 28, 2022

kevjumba added 2 commits June 27, 2022 23:48

Fix

e132df5

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Fix

1c00b99

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

kevjumba added ok-to-test and removed do-not-merge/work-in-progress labels Jun 28, 2022

felixwang9817 changed the title ~~feat: New dev build workflow to trigger before running release to make sure wheels can be built successfully~~ ci: New dev build workflow to trigger before running release to make sure wheels can be built successfully Jun 28, 2022

felixwang9817 changed the title ~~ci: New dev build workflow to trigger before running release to make sure wheels can be built successfully~~ ci: New workflow to build wheels Jun 28, 2022

felixwang9817 merged commit 82d96ae into feast-dev:master Jun 28, 2022

felixwang9817 mentioned this pull request Jul 5, 2022

Build wheels in CI without publishing #2857

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: New workflow to build wheels #2866

ci: New workflow to build wheels #2866

kevjumba commented Jun 27, 2022 •

edited

Loading

achals Jun 27, 2022

kevjumba Jun 27, 2022

achals Jun 27, 2022

kevjumba Jun 27, 2022

kevjumba commented Jun 27, 2022

codecov-commenter commented Jun 27, 2022 •

edited

Loading

achals Jun 27, 2022

kevjumba Jun 28, 2022

achals Jun 27, 2022

kevjumba Jun 28, 2022

felixwang9817 left a comment

feast-ci-bot commented Jun 28, 2022

ci: New workflow to build wheels #2866

ci: New workflow to build wheels #2866

Conversation

kevjumba commented Jun 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevjumba commented Jun 27, 2022

codecov-commenter commented Jun 27, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

felixwang9817 left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Jun 28, 2022

kevjumba commented Jun 27, 2022 •

edited

Loading

codecov-commenter commented Jun 27, 2022 •

edited

Loading