-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: New workflow to build wheels #2866
Conversation
.github/workflows/build_wheels.yml
Outdated
path: ./wheelhouse/*.whl | ||
|
||
|
||
build-python-sdk-macos-py310: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we move this into build-python-sdk
? And have a single step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
.github/workflows/build_wheels.yml
Outdated
echo $VERSION_WITHOUT_PREFIX | ||
echo $HIGHEST_SEMVER_TAG | ||
|
||
build-python-sdk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, build-python-wheel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
still doesn't work fixing |
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
- Coverage 80.67% 80.62% -0.06%
==========================================
Files 176 176
Lines 15671 15671
==========================================
- Hits 12643 12634 -9
- Misses 3028 3037 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
.github/workflows/build_wheels.yml
Outdated
- name: Build py310 wheel | ||
if: matrix.os == 'macos-10.15' | ||
run: | | ||
python3 setup.py sdist bdist_wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this if you remove cp310-macosx_x86_64
from CIBW_SKIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
.github/workflows/build_wheels.yml
Outdated
- name: Build and install dependencies go dependencies for py310 | ||
if: matrix.os == 'macos-10.15' | ||
run: | | ||
pip install -U pip setuptools wheel twine | ||
make install-protoc-dependencies | ||
make install-go-proto-dependencies | ||
make install-go-ci-dependencies | ||
make build-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
https://github.com/kevjumba/feast/runs/7087711627?check_suite_focus=true => Shows that this workflow works!
Which issue(s) this PR fixes:
Fixes #