Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fixing local integration tests, defaulting to test containers #2927

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Jul 8, 2022

This changes the local integration test flow to use the test containers.

  • It also extends the timeout for test containers because I was seeing flakiness locally.
  • It also checks for the docker daemon in the commands and fails if it's not running
  • It makes the local integration tests also run on PRs. This does not setup any cloud credentials and should work (emulates the dev workflow).

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #2927 (058304e) into master (130746e) will increase coverage by 19.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2927       +/-   ##
===========================================
+ Coverage   59.45%   78.52%   +19.07%     
===========================================
  Files         179      179               
  Lines       15870    15877        +7     
===========================================
+ Hits         9435    12467     +3032     
+ Misses       6435     3410     -3025     
Flag Coverage Δ
integrationtests 68.34% <87.50%> (?)
unittests 59.63% <75.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 85.63% <ø> (+29.88%) ⬆️
.../feature_repos/universal/online_store/datastore.py 50.00% <ø> (ø)
...n/feature_repos/universal/online_store/dynamodb.py 50.00% <ø> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <ø> (ø)
...tion/feature_repos/universal/online_store/redis.py 50.00% <ø> (ø)
sdk/python/tests/conftest.py 76.71% <100.00%> (+9.35%) ⬆️
...on/tests/integration/registration/test_registry.py 95.08% <100.00%> (+27.71%) ⬆️
sdk/python/feast/data_source.py 83.81% <0.00%> (+0.53%) ⬆️
sdk/python/feast/infra/online_stores/dynamodb.py 89.72% <0.00%> (+0.54%) ⬆️
sdk/python/feast/infra/registry_stores/sql.py 70.15% <0.00%> (+0.77%) ⬆️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130746e...058304e. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…d running local integration tests on PRs

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@kevjumba
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants