Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Feature Repo, Types and FAQ doc updates #3049

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

achals
Copy link
Member

@achals achals commented Aug 9, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #3049 (2e4e2a7) into master (af5123f) will increase coverage by 9.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
+ Coverage   67.59%   76.67%   +9.08%     
==========================================
  Files         168      198      +30     
  Lines       14712    16344    +1632     
==========================================
+ Hits         9944    12532    +2588     
+ Misses       4768     3812     -956     
Flag Coverage Δ
integrationtests 67.44% <ø> (-0.15%) ⬇️
unittests 58.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
...tores/contrib/trino_offline_store/trino_queries.py 15.05% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/spark_offline_store/tests/data_source.py 40.42% <0.00%> (ø)
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
...b/cassandra_online_store/cassandra_online_store.py 2.63% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.72% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
sdk/python/feast/infra/utils/hbase_utils.py 41.17% <0.00%> (ø)
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

docs/getting-started/concepts/data-ingestion.md Outdated Show resolved Hide resolved
docs/getting-started/concepts/feature-repo.md Outdated Show resolved Hide resolved
Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit e78d1d7 into feast-dev:master Aug 9, 2022
@@ -0,0 +1,13 @@
# Feature Repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achals oops just realized we already have a page for feature repos

we should make sure to merge this in with that page somehow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge

adchia pushed a commit that referenced this pull request Aug 10, 2022
* docs: Feature Repo, Types and FAQ doc updates

Signed-off-by: Achal Shah <achals@gmail.com>

* cr

Signed-off-by: Achal Shah <achals@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants