-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] loosen protobuf version constraints #3095
Conversation
[force version for tests] Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cburroughs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #3095 +/- ##
==========================================
- Coverage 67.12% 58.27% -8.85%
==========================================
Files 173 207 +34
Lines 15110 17016 +1906
==========================================
- Hits 10142 9916 -226
- Misses 4968 7100 +2132
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@cburroughs Hey Chris! Why are you pinning the protobuf version? This seems to do the opposite of what your pr title is describing. |
Also, on that front, I think our general motto is to not pin critical packages to specific versions unless absolutely necessary. I'm going to close this pr. Please feel free to reopen with a specific issue that you want resolved. |
I believe the pin was for testing. @cburroughs mentioned this in the community call/slack a couple of days ago. |
On 2022-08-18 13:46, Kevin Zhang wrote:
@cburroughs Hey Chris! Why are you pinning the protobuf version? This seems to do the opposite of what your pr title is describing.
Hi! This is my first time trying to do something with the feast codebase
and protobuf version have a strong 'here be dragons' vibe. As I
understand it there is specific code (#2484) that interacts with version
3.20.0+.
My rough plan was to:
* Verify that with 3.19, some tests fail.
* Modify code to work with <3.19 and >3.19.
* Verify tests pass with both.
That might not be viable, or maybe tensorflow and friends will update
their protobuf version faster and render this line of inquiry obsolete.
This PR was currently on the first step (and not yet successful as I
didn't understand the interaction between the versions in setup.py and
the .txt files).
|
@cburroughs I think #3103 actually resolves your issue? |
Fantastic! Thank you. |
[force version for tests]
Signed-off-by: Chris Burroughs chris.burroughs@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #