feat: Add AWS Redshift Serverless support #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to follow the development guide, but two problems; I don't seem to be able to add labels, and I did not see a field to add a release note? |
adchia
reviewed
Apr 21, 2023
setup.py
Outdated
| @@ -89,7 +91,7 @@ | |||
| "hiredis>=2.0.0,<3", | |||
| ] | |||
|
|
|||
| AWS_REQUIRED = ["boto3>=1.17.0,<=1.20.23", "docker>=5.0.2", "s3fs>=0.4.0,<=2022.01.0"] | |||
| AWS_REQUIRED = ["boto3>=1.24.11,<=1.24.95", "docker>=5.0.2", "s3fs>=0.4.0,<=2022.01.0"] | |||
There was a problem hiding this comment.
there's a separate PR on #3585 . After that goes in, want to rebase? You'll also have to run make lock-python-ci-dependencies PYTHON=x and make lock-python-dependencies PYTHON=x
There was a problem hiding this comment.
Yeah, sounds great, thanks for bringing that my attention! Watching that PR now.
cbarcroft
force-pushed
the
add-aws-redshift-serverless
branch
2 times, most recently
from
25bea6e
to
cb74e4f
Compare
Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com>
Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com>
Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, cbarcroft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chris Barcroft <christopher.barcroft@nordstrom.com>
Signed-off-by: Chris Barcroft <christopher.barcroft@nordstrom.com>
cbarcroft
force-pushed
the
add-aws-redshift-serverless
branch
from
cb74e4f
to
c15b86f
Compare
|
Sorry, looks like there was a casing error on one of the Redshift args |
|
/lgtm |
felixwang9817
pushed a commit
that referenced
this pull request
Apr 21, 2023
# [0.31.0](v0.30.0...v0.31.0) (2023-04-21) ### Bug Fixes * Add Stream Feature Views to helper that collect Feature View names ([#3582](#3582)) ([7854f63](7854f63)) * Add StreamFeatureViewSpec to FeastObjectSpecProto convenience type ([#3550](#3550)) ([3cefd6c](3cefd6c)) * Batch Snowflake materialization queries to obey Snowpark 100 fea… ([#3406](#3406)) ([f9862b5](f9862b5)) * Bytewax materializer security context ([#3573](#3573)) ([6794338](6794338)) * **cI:** Install coreutils in mac github workers for smoke test ([#3563](#3563)) ([e7421c1](e7421c1)) * Fix bug with no SqlRegistryConfig class ([#3586](#3586)) ([6dc1368](6dc1368)) * Fix Snowflake template ([#3584](#3584)) ([6c09c39](6c09c39)) * Make snowflake to remote tables temporary ([#3588](#3588)) ([ad48146](ad48146)) * Remove snowflake source warehouse tech debt ([#3422](#3422)) ([7da0580](7da0580)) * Snowflake remote storage ([#3574](#3574)) ([f8d3890](f8d3890)) * Support param timeout when persisting ([#3593](#3593)) ([01a98f0](01a98f0)) * Use pyarrow in a way that works across versions ([#3562](#3562)) ([1289f3f](1289f3f)) * Wrap the bigquery table name with backtick. ([#3577](#3577)) ([09f0e7e](09f0e7e)) ### Features * Add AWS Redshift Serverless support ([#3595](#3595)) ([58ce148](58ce148)) * Add Hazelcast as an online store ([#3523](#3523)) ([b05d50b](b05d50b)) * Cache Bigtable client ([#3602](#3602)) ([b27472f](b27472f)) * Relax aws extras requirements ([#3585](#3585)) ([7e77382](7e77382)) * Show bigquery datasource table and query on UI ([#3600](#3600)) ([58d63f7](58d63f7)) * Update snowflake offline store job output formats -- added arrow ([#3589](#3589)) ([be3e349](be3e349))
zerafachris
pushed a commit
to zerafachris/feast
that referenced
this pull request
Mar 5, 2024
* Rebase master Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com> * Pass optional types to satisfy mypy Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com> * Remove redundant import Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com> * Regenerate python requirements Signed-off-by: Chris Barcroft <christopher.barcroft@nordstrom.com> * Fix casing error on DbUser Redshift kwarg Signed-off-by: Chris Barcroft <christopher.barcroft@nordstrom.com> --------- Signed-off-by: Chris Barcroft <chrisabarcroft@gmail.com> Signed-off-by: Chris Barcroft <christopher.barcroft@nordstrom.com> Co-authored-by: Chris Barcroft <christopher.barcroft@nordstrom.com> Signed-off-by: zerafachris PERSONAL <zerafachris@gmail.com>
zerafachris
pushed a commit
to zerafachris/feast
that referenced
this pull request
Mar 5, 2024
# [0.31.0](feast-dev/feast@v0.30.0...v0.31.0) (2023-04-21) ### Bug Fixes * Add Stream Feature Views to helper that collect Feature View names ([feast-dev#3582](feast-dev#3582)) ([7854f63](feast-dev@7854f63)) * Add StreamFeatureViewSpec to FeastObjectSpecProto convenience type ([feast-dev#3550](feast-dev#3550)) ([3cefd6c](feast-dev@3cefd6c)) * Batch Snowflake materialization queries to obey Snowpark 100 fea… ([feast-dev#3406](feast-dev#3406)) ([f9862b5](feast-dev@f9862b5)) * Bytewax materializer security context ([feast-dev#3573](feast-dev#3573)) ([6794338](feast-dev@6794338)) * **cI:** Install coreutils in mac github workers for smoke test ([feast-dev#3563](feast-dev#3563)) ([e7421c1](feast-dev@e7421c1)) * Fix bug with no SqlRegistryConfig class ([feast-dev#3586](feast-dev#3586)) ([6dc1368](feast-dev@6dc1368)) * Fix Snowflake template ([feast-dev#3584](feast-dev#3584)) ([6c09c39](feast-dev@6c09c39)) * Make snowflake to remote tables temporary ([feast-dev#3588](feast-dev#3588)) ([ad48146](feast-dev@ad48146)) * Remove snowflake source warehouse tech debt ([feast-dev#3422](feast-dev#3422)) ([7da0580](feast-dev@7da0580)) * Snowflake remote storage ([feast-dev#3574](feast-dev#3574)) ([f8d3890](feast-dev@f8d3890)) * Support param timeout when persisting ([feast-dev#3593](feast-dev#3593)) ([01a98f0](feast-dev@01a98f0)) * Use pyarrow in a way that works across versions ([feast-dev#3562](feast-dev#3562)) ([1289f3f](feast-dev@1289f3f)) * Wrap the bigquery table name with backtick. ([feast-dev#3577](feast-dev#3577)) ([09f0e7e](feast-dev@09f0e7e)) ### Features * Add AWS Redshift Serverless support ([feast-dev#3595](feast-dev#3595)) ([58ce148](feast-dev@58ce148)) * Add Hazelcast as an online store ([feast-dev#3523](feast-dev#3523)) ([b05d50b](feast-dev@b05d50b)) * Cache Bigtable client ([feast-dev#3602](feast-dev#3602)) ([b27472f](feast-dev@b27472f)) * Relax aws extras requirements ([feast-dev#3585](feast-dev#3585)) ([7e77382](feast-dev@7e77382)) * Show bigquery datasource table and query on UI ([feast-dev#3600](feast-dev#3600)) ([58d63f7](feast-dev@58d63f7)) * Update snowflake offline store job output formats -- added arrow ([feast-dev#3589](feast-dev#3589)) ([be3e349](feast-dev@be3e349)) Signed-off-by: zerafachris PERSONAL <zerafachris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds support for optionally using a serverless workgroup rather than a provisioned cluster when utilizing the AWS Redshift offline store. Ultimately it is just a change in arguments given to boto3 functions (WorkgroupName vs ClusterIdentifier & DbUser), so this adds a configuration field, some validation, and passes the new field through to relevant functions, before ultimately deciding which keyword args to pass into boto3.
Which issue(s) this PR fixes:
N/A