Make redis key creation more determinisitic #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
woop
reviewed
Dec 21, 2019
ingestion/src/main/java/feast/store/serving/redis/FeatureRowToRedisMutationDoFn.java
Show resolved
Hide resolved
|
/lgtm |
zhilingc
force-pushed
the
0.3-ingestion-patch
branch
from
aea7c24
to
d1eefdf
Compare
|
/lgtm |
zhilingc
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Make redis key creation more determinisitic * Sort entity names
zhilingc
pushed a commit
to zhilingc/feast
that referenced
this pull request
Feb 12, 2020
feast-ci-bot
pushed a commit
that referenced
this pull request
Feb 13, 2020
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Feb 14, 2020
…v#471) * Make redis key creation more determinisitic (feast-dev#380) * Add documentation to RedisKey in Redis.proto Ensure entities are sorted by the name Co-authored-by: David Heryanto <david.heryanto@hotmail.com>
Merged
khorshuheng
pushed a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where depending on the upstream, we were not creating deterministic RedisKeys, causing lookups to fail. Also fixed issue where duplicate fields in incoming feature rows would bleed into the redis key.