Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update typeguard version to >=4.0.0 #3837

Merged
merged 1 commit into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/requirements/py3.10-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ traitlets==5.14.1
# nbformat
trino==0.327.0
# via feast (setup.py)
typeguard==2.13.3
typeguard==4.1.5
# via feast (setup.py)
types-protobuf==3.19.22
# via
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements/py3.10-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ toolz==0.12.1
# partd
tqdm==4.66.2
# via feast (setup.py)
typeguard==2.13.3
typeguard==4.1.5
# via feast (setup.py)
types-protobuf==4.24.0.20240129
# via mypy-protobuf
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements/py3.8-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ traitlets==5.14.1
# nbformat
trino==0.327.0
# via feast (setup.py)
typeguard==2.13.3
typeguard==4.1.5
# via feast (setup.py)
types-protobuf==3.19.22
# via
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements/py3.8-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ toolz==0.12.1
# partd
tqdm==4.66.2
# via feast (setup.py)
typeguard==2.13.3
typeguard==4.1.5
# via feast (setup.py)
types-protobuf==4.24.0.20240129
# via mypy-protobuf
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements/py3.9-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ traitlets==5.14.1
# nbformat
trino==0.327.0
# via feast (setup.py)
typeguard==2.13.3
typeguard==4.1.5
# via feast (setup.py)
types-protobuf==3.19.22
# via
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/requirements/py3.9-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ toolz==0.12.1
# partd
tqdm==4.66.2
# via feast (setup.py)
typeguard==2.13.3
typeguard==4.1.5
# via feast (setup.py)
types-protobuf==4.24.0.20240129
# via mypy-protobuf
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/tests/unit/test_feature_views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from datetime import timedelta

import pytest
from typeguard import TypeCheckError

from feast.aggregation import Aggregation
from feast.batch_feature_view import BatchFeatureView
Expand Down Expand Up @@ -278,7 +279,7 @@ def test_hash():


def test_field_types():
with pytest.raises(TypeError):
with pytest.raises(TypeCheckError):
Field(name="name", dtype=ValueType.INT32)


Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"tenacity>=7,<9",
"toml>=0.10.0,<1",
"tqdm>=4,<5",
"typeguard==2.13.3",
"typeguard>=4.0.0",
"fastapi>=0.68.0",
"uvicorn[standard]>=0.14.0,<1",
"gunicorn",
Expand Down
Loading