-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactoring to fix mypy linting #3947
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushwhackr
requested review from
sfc-gh-madkins,
niklasvm,
kevjumba,
yelo-blood and
sudohainguyen
as code owners
February 11, 2024 18:23
bushwhackr
force-pushed
the
bushwhackr/mypy
branch
from
February 11, 2024 18:24
658354f
to
275d162
Compare
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
bushwhackr
force-pushed
the
bushwhackr/mypy
branch
from
February 11, 2024 18:26
275d162
to
f0f7fec
Compare
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
sudohainguyen
added
ok-to-test
kind/techdebt
approved
and removed
kind/techdebt
approved
labels
Feb 12, 2024
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
bushwhackr
commented
Feb 13, 2024
Comment on lines
16
to
20
def create_data_source( | ||
self, | ||
df: pd.DataFrame, | ||
destination_name: str, | ||
event_timestamp_column="ts", | ||
created_timestamp_column="created_ts", | ||
field_mapping: Optional[Dict[str, str]] = None, | ||
timestamp_field: Optional[str] = None, | ||
**kwargs, | ||
) -> DataSource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality change: due to create_data_source needing an indeterminate number of arguments. The base class should accept kwargs and the concrete class should then process user arguments on whether sufficient inputs were given.
I'll wait for #3948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: mypy lint fixes, refer to: #3938
subset of mypy linting fixes when mypy version was upgraded in #3938.
The PR is getting alittle too long, so I'm breaking into another PR for the final fixes.
Which issue(s) this PR fixes:
Fixes #