Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic documentation generation for gRPC API #403

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

woop
Copy link
Member

@woop woop commented Jan 3, 2020

This PR uses protoc-gen-docs from the Istio project to generate gRPC API documentation for the Feast Serving and Core APIs. These reference docs will then be served through feast.dev.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator

zhilingc commented Jan 6, 2020

/lgtm

@woop
Copy link
Member Author

woop commented Jan 6, 2020

/test test-end-to-end-batch

@feast-ci-bot feast-ci-bot merged commit 2b291a3 into feast-dev:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants