-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add missing CI for feast-operator image builds #4184
base: master
Are you sure you want to change the base?
Conversation
@woop is this something you can help with? the creation of those repos that is. |
Checking this out right now. |
Just to confirm, is there a reason we'd use kf-feast on GCR instead of dockerhub? Also, @franciscojavierarceo can you confirm what access you have already? |
@woop its used in |
I have access to Dockerhub but not gcr |
Hey @franciscojavierarceo you should have GCR access now if you check your GCP console. |
7c8a265
to
070c8d4
Compare
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
070c8d4
to
1719d65
Compare
@franciscojavierarceo @woop were these repos ever added? should we revisit this? it may help us troubleshoot some of the release build issues we've been facing. don't forget to add write perms for the gh actions robot account. |
Sorry been out of the loop on this one @tchughesiv does this still need review or action from me? |
What this PR does / why we need it:
Missing CI related to #4145
This change will require that the following image repos are created (if they don't already exist) -
Which issue(s) this PR fixes:
#4144