Update GKE installation and chart values to work with 0.4.3 #434
Conversation
lgvital
requested review from
davidheryanto,
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
|
Hi @lgvital. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @woop |
|
/ok-to-test |
| # jvmOptions are options that will be passed to the Java Virtual Machine (JVM) | ||
| # Specify what image tag to use. Keep this consistent for all components | ||
| image: | ||
| tag: "0.4.3" |
There was a problem hiding this comment.
I think we also need to remove the existing image tag from the helm charts. I believe it is currently hardcoded.
|
Thanks so much for this @lgvital. I just had a quick look and it looks great. I think we can safely merge this in for the time being, I will add more content a bit later. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lgvital, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No prob, thanks for the help and quick review! |
* Update Changelog (#423) * Initial commit of changelog up to 0.4.3 * Remove unreleased changes on master * Add missing changelog manually Co-authored-by: Khor Shu Heng <32997938+khorshuheng@users.noreply.github.com> * Introduce datatypes/java module for proto generation (#391) Rather than the Maven protobuf plugin running on the same symlinked definitions in several Java modules, localize this process into one module that the others depend on. This provides a single module that can be depended on by third-party extensions with the bare minimum of dependencies. Also removes proto files that are no longer used. * Update basic Feast example to Feast 0.4 (#424) * Add documentation for bigquery batch retrieval (#428) * Add documentation for bigquery batch retrieval * Fix formatting for multiline comments * Bump hibernate-validator from 6.0.13.Final to 6.1.0.Final in /ingestion (#421) Bumps [hibernate-validator](https://github.com/hibernate/hibernate-validator) from 6.0.13.Final to 6.1.0.Final. - [Release notes](https://github.com/hibernate/hibernate-validator/releases) - [Changelog](https://github.com/hibernate/hibernate-validator/blob/master/changelog.txt) - [Commits](hibernate/hibernate-validator@6.0.13.Final...6.1.0.Final) Signed-off-by: dependabot[bot] <support@github.com> * Publish datatypes/java along with sdk/java (#426) This forward-ports a straggling commit from #407: it was missed when initially creating the datatypes module because Sonatype publishing setup was added concurrently. * Remove "resource" concept and the need to specify a kind in feature sets (#432) * Update GKE installation and chart values to work with 0.4.3 (#434) * Fix logging (#430) Allow log level to be set via environmental variable. Add ability to set appender type in serving. Remove logback-classic from ingestion as it is a library so should not bring its own impl. Upgrade log4j to 2.12.1 to support objectMessageAsJsonObject. Fix logger config targeting feast package in serving an add same concept for core. * Bump chart version * Update Changelog (#447) * Update Changelog * Remove closed issues Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Co-authored-by: Ches Martin <ches@whiskeyandgrits.net> Co-authored-by: Chen Zhiling <chnzhlng@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lionel Vital <lgvital@gmail.com> Co-authored-by: Iain Rauch <Yanson@users.noreply.github.com>
What this PR does / why we need it: GKE docs and charts are outdated and do not work end-to-end. This PR should do the minimum to fix it. Mostly thanks to @woop who helped me debug the issues and find holes in current docs/charts.
values.yaml.The end result is anybody should be able to follow these docs +
values.yamlto create a feast cluster in GKE and have ingestion, online serving, and batch serving deployed on a publicly accessible IP.Which issue(s) this PR fixes:
Fixes #427
Fixes #349
Does this PR introduce a user-facing change?: