-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow feast snowflake to read in byte string for private-key authentication #4384
feat: Allow feast snowflake to read in byte string for private-key authentication #4384
Conversation
…cation Signed-off-by: Artur <artur.kolakowski@medely.com>
just curious, are you able to set bytes value from yaml as well or will this only work in python? |
Signed-off-by: Artur <artur.kolakowski@medely.com>
Signed-off-by: Artur <artur.kolakowski@medely.com>
yes it will work, for example,
|
Signed-off-by: Artur <artur.kolakowski@medely.com>
Wouldn't that be interpreted as a string and therefore as a file path? |
As I am looking through the code base and considering this example:
when |
@arturkolakowski how about we add another field in config instead (something like |
…th by reading in byte string Signed-off-by: Artur <artur.kolakowski@medely.com>
Signed-off-by: Artur <artur.kolakowski@medely.com>
@tokoko Made changes based on the request |
Signed-off-by: Artur <artur.kolakowski@medely.com>
Signed-off-by: Artur <artur.kolakowski@medely.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
…thentication (feast-dev#4384) * allow feast snowflake to read in byte string for private-key authentication Signed-off-by: Artur <artur.kolakowski@medely.com> * Update type hint for to use Union instead of | syntax Signed-off-by: Artur <artur.kolakowski@medely.com> * Update type hint for private_key to use Union instead of | syntax Signed-off-by: Artur <artur.kolakowski@medely.com> * Update type hint in parse_private_key_path Signed-off-by: Artur <artur.kolakowski@medely.com> * added private_key_content in Snowflake configs to support key-pair auth by reading in byte string Signed-off-by: Artur <artur.kolakowski@medely.com> * fix incompatible linting types Signed-off-by: Artur <artur.kolakowski@medely.com> * remove unused Union import Signed-off-by: Artur <artur.kolakowski@medely.com> * fix formating Signed-off-by: Artur <artur.kolakowski@medely.com> --------- Signed-off-by: Artur <artur.kolakowski@medely.com> Co-authored-by: Artur <artur.kolakowski@medely.com>
What this PR does / why we need it:
Allows the user to pass private_key as a byte string for Snowflake key-pair authentication rather than only limiting the ability to refer to the file path where the private key is stored.
Gives the ability to pass in
private_key
from a Secret Manager service (i.e: Google Cloud Secret Manager)Which issue(s) this PR fixes:
Fixes