Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Explicit protobuf build version; consistent build/setup deps #4472

Merged
merged 1 commit into from
Sep 3, 2024

Commits on Aug 30, 2024

  1. build: explicit protobuf build version; consistent build/setup deps

    Right now if one downloads `feast-0.40.1-py2.py3-none-any.whl` from
    PyPi it contains:
    ```
    $ grep 'Protobuf Python Version' feast/protos/feast/registry/RegistryServer_pb2.py
    ```
    Which is outside
    ```
    $ grep 'protobuf<' feast-0.40.1.dist-info/METADATA
    Requires-Dist: protobuf<5.0.0,>=4.24.0
    ```
    Leading to runtime errors (feast-dev#4437).  This was mitigated by feast-dev#4438.  This
    change tightens this up further by:
     * Deleting the Makefile command that was trying to do this
     unsuccessfully.
     * Aligns the setup/build requirements
     * Sets the version of protobuf to match the *minimum* of the range.
     There is no guarantee that protos generated by `4.X` will work with `4.(X-1)`.
    
    Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
    cburroughs committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2aa12ea View commit details
    Browse the repository at this point in the history