fix: Remove Feast UI TypeScript dependencies from peerDependencies and dependencies
#4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type declaration files are only used during development and not included in the runtime code, so they should be in devDependencies. We also shouldn't require dependent projects to install them by including them in peerDependencies. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
TypeScript is a development dependency, so there is no need to require it from dependent projects via peer dependencies. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
peruukki
changed the title
peerDependencies and dependencies
franciscojavierarceo
approved these changes
Sep 21, 2024
|
probably you need the npm website access? https://www.npmjs.com/package/@feast-dev/feast-ui |
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
Sep 23, 2024
…and `dependencies` (feast-dev#4554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Two commits to clean up the Feast UI
dependenciesorpeerDependencies:@typespackages fromdependenciestodevDependenciesand remove them frompeerDependencies:devDependencies. The DefinitelyTyped docs also include--save-devin installation commands for this.peerDependencies; the projects don't necessarily use TypeScript.typescriptfrompeerDependenciesfor similar reasons: it's only used during development and the dependent project is free to use whichever version of TypeScript or even not use it.Which issue(s) this PR fixes:
This is related to #3785 and partially resolves it, but I wouldn't close the issue still with this. I think there are still other packages in
peerDependenciesthat don't need to, but I wanted to improve the situation with the TypeScript related ones separately with this PR.