fix: Remove Feast UI TypeScript dependencies from peerDependencies
and dependencies
#4554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Two commits to clean up the Feast UI
dependencies
orpeerDependencies
:@types
packages fromdependencies
todevDependencies
and remove them frompeerDependencies
:devDependencies
. The DefinitelyTyped docs also include--save-dev
in installation commands for this.peerDependencies
; the projects don't necessarily use TypeScript.typescript
frompeerDependencies
for similar reasons: it's only used during development and the dependent project is free to use whichever version of TypeScript or even not use it.Which issue(s) this PR fixes:
This is related to #3785 and partially resolves it, but I wouldn't close the issue still with this. I think there are still other packages in
peerDependencies
that don't need to, but I wanted to improve the situation with the TypeScript related ones separately with this PR.