Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test FeatureView apply to expose entity_columns behavior pre and post apply() #4571

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

franciscojavierarceo
Copy link
Member

What this PR does / why we need it:

Feature Views have the property that during class instantiation, entity columns are not serialized to populate DUMMY_ENTITY_ID but are populated after the FeatureStore.apply() method is called. This PR tests that behavior explicitly.

Which issue(s) this PR fixes:

N/A

Misc

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…y columns

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Copy link
Collaborator

@shuchu shuchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo franciscojavierarceo merged commit 626c94f into master Sep 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants