fix: Fixing failure of protos during ODFV transformations for missing entities #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entities Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
changed the title
franciscojavierarceo
requested review from
tokoko,
HaoXuAI,
sudohainguyen and
shuchu
|
FYI @job-almekinders |
|
Amazing, thanks a lot for this Francisco! 🙌 FYI @TomSteenbergen |
emgeee
pushed a commit
to emgeee/feast
that referenced
this pull request
Oct 23, 2024
emgeee
pushed a commit
to emgeee/feast
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes failure of proto type adjustment during ODFV transformations for missing entities
Which issue(s) this PR fixes:
#4473
Misc