chore: Eject Create React App dependency from Feast UI #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
The presets are set in .babelrc.js. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
These two dependencies can now be upgraded after ejecting. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
This keeps package.json cleaner. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Strict mode is implicit in modules, so ESLint gave warnings about using them in the scripts. However, the scripts are run directly with `node`, so they are not used as modules. But setting their sourceType to "script" results in ESLint errors saying "Strict mode is not permitted." I couldn't figure out why, so let's just disable the rule for the scripts. Later I noticed the same warning in the config directory, so let's include that too. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Create React App (CRA) hasn't really been updated in recent years. I couldn't find anything official on it being deprecated, but at least there's this discussion from Jan 2023 on not recommending it anymore, Vite being a popular replacement.
Replacing the current CRA-based setup with something else would be a big task, and it's not something we necessarily have to do, but ejecting would be the first step. It removes the dependency on
react-scriptsand copies all configuration files to our project, so we can modify them as we please. It also allows us to upgrade a couple dependencies that have vulnerabilities, so it's immediately useful.This PR does the ejecting in the first commit, then cleans up things in the following commits. Most of the new files and changes in existing ones were automatically generated by the
yarn ejectcommand, and I didn't touch them, so there should be no change in behavior.Which issue(s) this PR fixes:
I would say this resolves #4451 since after these changes, there is only one
cookievulnerability left, and to resolve that we'll have to wait for an update in msw like mentioned in #4654.