Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing testing in Milvus, Makefile, and repo_configuration #4881

Merged
merged 4 commits into from
Dec 28, 2024
Merged

chore: Fixing testing in Milvus, Makefile, and repo_configuration #4881

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4898931
chore: Fixing testing in Milvus, Makefile, and repo_configuration
franciscojavierarceo Dec 27, 2024
696f1af
adjusted variable name
franciscojavierarceo Dec 27, 2024
20cbb4f
linter
franciscojavierarceo Dec 27, 2024
3839110
removed connection_string argument in config definition
franciscojavierarceo Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ test-python-universal-milvus-online:
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.milvus_online_store.milvus_repo_configuration \
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.milvus \
python -m pytest -n 8 --integration \
-k "test_retrieve_online_milvus_ocuments" \
-k "test_retrieve_online_milvus_documents" \
sdk/python/tests --ignore=sdk/python/tests/integration/offline_store/test_dqm_validation.py

test-python-universal-singlestore-online:
Expand Down
5 changes: 5 additions & 0 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
)

DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
MILVUS_CONFIG = {"type": "milvus", "connection_string": "localhost:19530"}
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
REDIS_CLUSTER_CONFIG = {
"type": "redis",
Expand Down Expand Up @@ -162,6 +163,7 @@
AVAILABLE_ONLINE_STORES["datastore"] = ("datastore", None)
AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)
AVAILABLE_ONLINE_STORES["bigtable"] = (BIGTABLE_CONFIG, None)
AVAILABLE_ONLINE_STORES["milvus"] = (MILVUS_CONFIG, None)

# Uncomment to test using private IKV account. Currently not enabled as
# there is no dedicated IKV instance for CI testing and there is no
Expand Down Expand Up @@ -559,6 +561,9 @@ def construct_test_environment(
cache_ttl_seconds=1,
)

if test_repo_config.online_store in ["milvus", "pgvector", "qdrant"]:
entity_key_serialization_version = 3

environment_params = {
"name": project,
"provider": test_repo_config.provider,
Expand Down
8 changes: 4 additions & 4 deletions sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,8 +862,8 @@ def assert_feature_service_entity_mapping_correctness(

@pytest.mark.integration
@pytest.mark.universal_online_stores(only=["pgvector", "elasticsearch", "qdrant"])
def test_retrieve_online_documents(vectordb_environment, fake_document_data):
fs = vectordb_environment.feature_store
def test_retrieve_online_documents(environment, fake_document_data):
fs = environment.feature_store
df, data_source = fake_document_data
item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
fs.apply([item_embeddings_feature_view, item()])
Expand Down Expand Up @@ -899,8 +899,8 @@ def test_retrieve_online_documents(vectordb_environment, fake_document_data):

@pytest.mark.integration
@pytest.mark.universal_online_stores(only=["milvus"])
def test_retrieve_online_milvus_documents(vectordb_environment, fake_document_data):
fs = vectordb_environment.feature_store
def test_retrieve_online_milvus_documents(environment, fake_document_data):
fs = environment.feature_store
df, data_source = fake_document_data
item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
fs.apply([item_embeddings_feature_view, item()])
Expand Down
Loading