Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate golang code for non-serving protos #618

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

zhilingc
Copy link
Collaborator

What this PR does / why we need it:
For external systems to interface with Feast using golang, we need to persist the generated code for the core service in the repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 4f01f17 into feast-dev:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants