Add ability to submit ingestion job using Flink #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 11, 2019 10:22
zhilingc
requested changes
Jan 11, 2019
core/src/main/java/feast/core/service/JobManagementService.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 12, 2019 08:59
… runs in blocking fashion
zhilingc
approved these changes
Jan 12, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unassign woop Think @tims should review this instead of me. It looks fine to me personally. |
tims
reviewed
Jan 18, 2019
| throw new IllegalStateException("Unable to initialize DataflowJobManager", e); | ||
| } | ||
| case FLINK: | ||
| org.apache.flink.configuration.Configuration configuration = |
There was a problem hiding this comment.
Minor suggestion.. I think this construction code should be moved to a factory style method of the FlinkJobManager.
Similarly for the DataflowJobManager.
|
/lgtm |
Yanson
pushed a commit
to Yanson/feast
that referenced
this pull request
Jul 29, 2020
…_redis_password Redis security (added password to redis)
dmartinol
pushed a commit
to dmartinol/feast
that referenced
this pull request
Aug 5, 2024
…ent-interceptor-auth Created the grpc client auth header interceptor and removed the manua…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to submit ingestion job to a Flink Cluster in detached mode.
To enable it, set following environment variable:
What's not done:
Fix #21