Add support for feature set updates and remove versions #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhilingc
requested review from
davidheryanto,
khorshuheng,
pradithya and
woop
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zhilingc
force-pushed
the
version-removal-b
branch
6 times, most recently
from
d06868b
to
37a2c6e
Compare
woop
requested changes
May 5, 2020
There was a problem hiding this comment.
Is it possible for us to create integration/regression tests with the Python SDK that tests the feature addition or removal steps
- Read dataframe (filter a few columns)
- Infer a feature set and apply to Feast Core
- Ingest first half of dataframe (rows)
- Unfilter the previously filtered columns and filter other columns
- Infer a feature set and apply to Feast Core
- Ingest second half of dataframe (rows)
- Retrieve across all feature columns for complete history (should fail because of archival)
- Retrieve across current good feature columns for complete history (should return data over complete time range, but with gaps in the features that were filtered in step 1)
ingestion/src/main/java/feast/ingestion/transform/fn/ValidateFeatureRowDoFn.java
Outdated
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/transform/fn/ValidateFeatureRowDoFn.java
Show resolved
Hide resolved
zhilingc
force-pushed
the
version-removal-b
branch
2 times, most recently
from
e991dc1
to
3617b33
Compare
mrzzy
reviewed
May 6, 2020
woop
changed the title
woop
added
compat/breaking
|
Should we add a note that versions will be ignored hence forth? |
ches
reviewed
May 7, 2020
woop
reviewed
May 8, 2020
woop
reviewed
May 8, 2020
|
/retest |
added 18 commits
May 13, 2020 14:30
…ts instead of advancing version
…atureSet.status to use enum directly
zhilingc
force-pushed
the
version-removal-b
branch
from
04bf88b
to
e27e203
Compare
woop
reviewed
May 13, 2020
woop
reviewed
May 13, 2020
zhilingc
force-pushed
the
version-removal-b
branch
from
57144d3
to
2e9ff4e
Compare
zhilingc
force-pushed
the
version-removal-b
branch
from
2e9ff4e
to
6bbfede
Compare
|
/lgtm |
ches
reviewed
May 13, 2020
| @@ -69,9 +69,6 @@ message FeatureReference { | |||
| // Feature name | |||
| string name = 2; | |||
|
|
|||
| // Feature version | |||
| int32 version = 3; | |||
ches
reviewed
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Addresses #386, and implemented in accordance with this RFC.
For backward compatibility, user facing code still allows users to provide versions, but they will be ignored.
This PR is built on top of #655.
Which issue(s) this PR fixes:
Fixes #386
Does this PR introduce a user-facing change?: