-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for feature set updates and remove versions #676
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d06868b
to
37a2c6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for us to create integration/regression tests with the Python SDK that tests the feature addition or removal steps
- Read dataframe (filter a few columns)
- Infer a feature set and apply to Feast Core
- Ingest first half of dataframe (rows)
- Unfilter the previously filtered columns and filter other columns
- Infer a feature set and apply to Feast Core
- Ingest second half of dataframe (rows)
- Retrieve across all feature columns for complete history (should fail because of archival)
- Retrieve across current good feature columns for complete history (should return data over complete time range, but with gaps in the features that were filtered in step 1)
ingestion/src/main/java/feast/ingestion/transform/fn/ValidateFeatureRowDoFn.java
Outdated
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/transform/fn/ValidateFeatureRowDoFn.java
Show resolved
Hide resolved
e991dc1
to
3617b33
Compare
Should we add a note that versions will be ignored hence forth? |
/retest |
…ts instead of advancing version
…atureSet.status to use enum directly
04bf88b
to
e27e203
Compare
57144d3
to
2e9ff4e
Compare
2e9ff4e
to
6bbfede
Compare
/lgtm |
@@ -69,9 +69,6 @@ message FeatureReference { | |||
// Feature name | |||
string name = 2; | |||
|
|||
// Feature version | |||
int32 version = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reserved
for this one too?
What this PR does / why we need it:
Addresses #386, and implemented in accordance with this RFC.
For backward compatibility, user facing code still allows users to provide versions, but they will be ignored.
This PR is built on top of #655.
Which issue(s) this PR fixes:
Fixes #386
Does this PR introduce a user-facing change?: