Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version method in Feast SDK and Core #759

Merged
merged 2 commits into from
May 30, 2020

Conversation

woop
Copy link
Member

@woop woop commented May 30, 2020

What this PR does / why we need it:

Currently the Python SDK's version() method doesn't work because it remains unimplemented in Feast Core. This PR allows versions to be returned to the client.

Does this PR introduce a user-facing change?:

Retrieving the version of Feast Core is now supported and available through the Python SDK

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop changed the title Add support for version method in Feast Add support for version method in Feast SDK and Core May 30, 2020
@woop woop merged commit a5c6dce into feast-dev:master May 30, 2020
@woop woop added kind/feature New feature or request and removed needs-kind labels May 30, 2020
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Jun 5, 2020
* Add support for version method

* Fix typo in e2e tests for version method
khorshuheng pushed a commit that referenced this pull request Jun 5, 2020
* Add support for version method

* Fix typo in e2e tests for version method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants