Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish helm chart script should not modify the chart content #779

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

khorshuheng
Copy link
Collaborator

Which issue(s) this PR fixes:
The current publish helm chart script modifies the existing charts in the repository before publishing the chart. The original intention is that, should a developer forgot to update the version, the script will automatically correct the mistake.

However, this preprocessing is currently modifying the versions of the non-feast dependencies. As a result the helm chart publication job will fail due to dependency not being met (eg. Prometheus).

This PR remove the preprocessing step. Instead the developer should explicitly update the image/tag version in the release branch.

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 7, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7b537f0 into feast-dev:master Jun 7, 2020
@feast-ci-bot
Copy link
Collaborator

@khorshuheng: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

Which issue(s) this PR fixes:
The current publish helm chart script modifies the existing charts in the repository before publishing the chart. The original intention is that, should a developer forgot to update the version, the script will automatically correct the mistake.

However, this preprocessing is currently modifying the versions of the non-feast dependencies. As a result the helm chart publication job will fail due to dependency not being met (eg. Prometheus).

This PR remove the preprocessing step. Instead the developer should explicitly update the image/tag version in the release branch.

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhangchi1 pushed a commit to Cimpress-MCP/feast that referenced this pull request Jun 11, 2020
…dev#779)

Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants