Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for listing feature sets using labels #785

Merged
merged 18 commits into from
Jun 17, 2020
Merged

Add API for listing feature sets using labels #785

merged 18 commits into from
Jun 17, 2020

Conversation

terryyylim
Copy link
Member

@terryyylim terryyylim commented Jun 9, 2020 •
edited by woop
Loading

What this PR does / why we need it:
Adds listing functionality using labels for FeatureSet

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

User can now list feature sets by labels

@terryyylim terryyylim added the kind/feature New feature or request label Jun 9, 2020
@terryyylim
Copy link
Member Author

/test test-end-to-end-redis-cluster

@terryyylim
Copy link
Member Author

/test test-end-to-end

@terryyylim
Copy link
Member Author

/test test-end-to-end-batch

@terryyylim terryyylim changed the title [WIP] Discovery fs api Discovery fs api Jun 10, 2020
@terryyylim terryyylim changed the title Discovery fs api Add Discovery API for searching FeatureSets Jun 10, 2020
woop
woop reviewed Jun 11, 2020
View reviewed changes
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
woop
woop reviewed Jun 11, 2020
View reviewed changes
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
woop
woop reviewed Jun 11, 2020
View reviewed changes
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
woop
woop reviewed Jun 11, 2020
View reviewed changes
sdk/python/feast/client.py Outdated Show resolved Hide resolved
woop
woop reviewed Jun 11, 2020
View reviewed changes
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
@terryyylim
Copy link
Member Author

/test test-end-to-end-redis-cluster

@terryyylim terryyylim changed the title Add Discovery API for searching FeatureSets Add Discovery API for listing FeatureSets using labels Jun 13, 2020
@ches ches added this to the v0.6.0 milestone Jun 16, 2020
@woop woop changed the title Add Discovery API for listing FeatureSets using labels Add API for listing feature sets using labels Jun 17, 2020
@woop
Copy link
Member

woop commented Jun 17, 2020

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jun 17, 2020
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jun 17, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit a5bd877 into feast-dev:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels
approved kind/feature New feature or request lgtm size/L
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@terryyylim @woop @feast-ci-bot @ches