Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep StoreProto inside JobStore to decouple JobCoordination from SpecService internals #852

Merged
merged 4 commits into from
Jul 1, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jul 1, 2020

What this PR does / why we need it:

This PR reverts #846 to keep Job and Store more decoupled (and not use StoreRepository from JobCoordinator).
Now Job keeps full copy of related Stores (in proto) in jobs_stores table. It allows us to compare deployed stores with new one coming from SpecService and upgrade IngestionJob if needed.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@pyalex pyalex changed the title Keep StoreProto inside JobStore to decouple Job from Store Keep StoreProto inside JobStore to decouple JobCoordination from SpecService internals Jul 1, 2020
@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-auth

@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-redis-cluster

@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/retest

@woop
Copy link
Member

woop commented Jul 1, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-batch

@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-auth

1 similar comment
@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-auth

@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-auth

1 similar comment
@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end-auth

@feast-ci-bot feast-ci-bot merged commit fdbc376 into feast-dev:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants