Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BQ Sink is failing when Feature consists of only null values #853

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jul 1, 2020

What this PR does / why we need it:

Schema can't be inferred when one of the features has only nulls in FeatureRowBatch that is used to compress FeatureRows while waiting for BQ job to load.
This PR fixes NPE

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jul 1, 2020

/lgtm

@pyalex
Copy link
Collaborator Author

pyalex commented Jul 1, 2020

/test test-end-to-end

@feast-ci-bot feast-ci-bot merged commit 9a037dc into feast-dev:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants