Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impute default project if empty before authorization is called #926

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

jmelinav
Copy link
Collaborator

@jmelinav jmelinav commented Aug 3, 2020

What this PR does / why we need it:
if project is not set in the featureSet, which is in the request for applyFeatureSet method, an empty project will be passed for authorization. Instead it should authorize against default project.
Which issue(s) this PR fixes:

Related to #793

Does this PR introduce a user-facing change?:no

In 'applyFeatureSet' api, project name imputation happens before invoking authorization service. 
Previous behavior, only 'admin' user could create feature sets in 'default' project, 
and authorization was failing for users who have access to 'default' project, 
since authorization was being invoked with empty 'projectId'. 

@feast-ci-bot
Copy link
Collaborator

Hi @jmelinav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav
Copy link
Collaborator Author

jmelinav commented Aug 3, 2020

/assign @pyalex

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelinav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmelinav
Copy link
Collaborator Author

jmelinav commented Aug 5, 2020

/ok-to-test

@feast-ci-bot
Copy link
Collaborator

@jmelinav: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav
Copy link
Collaborator Author

jmelinav commented Aug 5, 2020

/kind bug

@woop
Copy link
Member

woop commented Aug 7, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit f537863 into feast-dev:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants