Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass authentication for metric endpoints on Serving. #936

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Bypass authentication for metric endpoints on Serving. #936

merged 2 commits into from
Aug 6, 2020

Conversation

mrzzy
Copy link
Collaborator

@mrzzy mrzzy commented Aug 6, 2020

What this PR does / why we need it:
Follow up of #862 to extend Authentication Bypass for metrics access to Serving for the /metrics and /actuator endpoints.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khorshuheng
Copy link
Collaborator

/test test-end-to-end-batch

1 similar comment
@khorshuheng
Copy link
Collaborator

/test test-end-to-end-batch

@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Aug 6, 2020
@mrzzy
Copy link
Collaborator Author

mrzzy commented Aug 6, 2020

/test test-end-to-end-batch

@khorshuheng khorshuheng requested review from khorshuheng and removed request for zhilingc August 6, 2020 07:43
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, mrzzy, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrzzy
Copy link
Collaborator Author

mrzzy commented Aug 6, 2020

/test test-end-to-end-batch

@pyalex
Copy link
Collaborator

pyalex commented Aug 6, 2020

/test test-end-to-end-batch-dataflow

@pyalex
Copy link
Collaborator

pyalex commented Aug 6, 2020

/lgtm

@pyalex pyalex merged commit 74beb5d into feast-dev:master Aug 6, 2020
@feast-ci-bot
Copy link
Collaborator

@mrzzy: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-batch-dataflow 3b44161 link /test test-end-to-end-batch-dataflow

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants