-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Relax Python Dependencies #954
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SwampertX The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The current update is done by
Appreciate comments on what is the best practice here. |
@SwampertX: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
"numpy", | ||
"google", | ||
"confluent_kafka", | ||
"click>=7.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these really the lowest versions we can use? (everything in REQUIRED
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are the latest versions we can use instead. This way the dependencies will not be outdated for longer, but is likely going to conflict with old packages. Although no conflicts are detected when I last tested the dependencies by installing in a new virtualenv
with tensorflow==2.3.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea but basically, if somebody is running Pandas 1.0.0 then Feast wont work for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SwampertX I agree with @woop, the dependency requirements should be as low as possible since many of our existing users are using older version of library.
What this PR does / why we need it:
Feast's Python SDK has dependencies that clash with popular data science libraries, like
pandas
andpyyaml
. This PR aims to fix that, and perhaps find a most suitable way to do this.Which issue(s) this PR fixes:
Fixes #928
Does this PR introduce a user-facing change?: