Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable kafka consumer in IngestionJob #959

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Aug 24, 2020

What this PR does / why we need it:

Kafka consumer that pulls FeatureRows from source should be configurable (via jobcontroller application properties) to be able to tune it for better performance.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

application.yml in jobcontroller

feast:
  jobs:
    runners:
    - name: dataflow
      options:
        kafkaConsumerProperties:
          "max.poll.records": "50000"
          "receive.buffer.bytes": "33554432"

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 24, 2020

/test test-end-to-end-auth

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop added the kind/feature New feature or request label Aug 25, 2020
@woop
Copy link
Member

woop commented Aug 25, 2020

/lgtm

@woop
Copy link
Member

woop commented Aug 25, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 513ada6 into feast-dev:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants