Fix docker-compose test #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
woop
reviewed
Sep 1, 2020
woop
reviewed
Sep 1, 2020
.github/workflows/master_only.yml
Outdated
| @@ -64,4 +64,4 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Test docker compose | |||
| run: ./infra/scripts/test-docker-compose.sh | |||
| run: ./infra/scripts/test-docker-compose.sh ${GITHUB_SHA} | |||
There was a problem hiding this comment.
I think it might also be better to move this test to the complete workflow, along with the load test. So that it depends on the images being built.
|
Did you also have a look at the load test that is failing? https://github.com/feast-dev/feast/runs/1055084887?check_suite_focus=true |
terryyylim
force-pushed
the
fix-docker-compose-test
branch
from
0134e8a
to
af6a3d4
Compare
|
/retest |
1 similar comment
|
/retest |
woop
approved these changes
Sep 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
tests-docker-composetest that triggers when PRs are merged to master branch currently runs tests on a specific version (eg. 0.6.2) image. This causes test failures since Dockerfiles may have changed since a specific version tag.Which issue(s) this PR fixes:
Fixes #956
Does this PR introduce a user-facing change?: