Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optionally building without plugin-host #540

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Plecra
Copy link

@Plecra Plecra commented Feb 8, 2022

Status

  • Ready
  • Development
  • Hold

Description

This was fantastic! The implementation was already very cleanly separated so it wasn't any trouble to turn plugin-host off all together. This saves a bunch of compilation time for me 😁

I'm not very well versed in github actions, but I've made an attempt at extending the CI to test both with and without the plugins enabled. Let's see if it works...

Related issues

Leave empty if none

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

@Plecra
Copy link
Author

Plecra commented Feb 8, 2022

uhh that's funny. it built just fine on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant