Update to new plugin infrastructure #591
Conversation
| statements: [50, 80] |
There was a problem hiding this comment.
Don't want to bump these watermarks up? I think we should aim for > 90% or >95% coverage on core modules.
There was a problem hiding this comment.
We can do that in bulk for all repos once they are done.
| @@ -1,12 +1,10 @@ | |||
| .editorconfig | |||
| .jshintrc | |||
There was a problem hiding this comment.
probably need .eslintrc.yml in there instead of .jshintrc
| @@ -1,107 +0,0 @@ | |||
| // TODO: don't have the defs from the hooks PR yet, fix later | |||
There was a problem hiding this comment.
Is this moved to the https://github.com/feathersjs-ecosystem/feathers-typescript repo? Just curious.
There was a problem hiding this comment.
Yeah, will be. I don't want to mess with our repos because TypeScript definitions are broken all the time. They'll be published separately and then pulled in.
package.json
Outdated
| "lint": "semistandard --fix", | ||
| "mocha": "mocha --opts mocha.opts", | ||
| "test": "npm run compile && npm run lint && npm run coverage && nsp check", | ||
| "test": "npm run lint && npm run coverage", |
There was a problem hiding this comment.
Are we dropping the nsp check? Does Greenkeeper cover us there?
There was a problem hiding this comment.
Nah, good call, added it back.
For feathersjs/feathers#608