This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
fix(hasRoleOrRestrict): usage w/ get method returns correct result #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously the hasRoleOrRestrict hook failed to return data in the expected format when used on a Service#get method due to incorrect handling of the result of the internal call to Service#find. as Service#find returns an object with a "data" property that is always an array, we can safely check the nested value and correctly determine if the pseudo-get method call was successful. any application code hacking around the issue by knowingly pulling the nested "data" prop from the result will now break.
daffl
previously requested changes
Oct 11, 2017
There was a problem hiding this comment.
Thank you @meatwallace. One thing that I think has to be changed, otherwise this makes sense.
src/has-role-or-restrict.js
Outdated
| @@ -54,8 +54,8 @@ export default function (options = {}) { | |||
| } | |||
|
|
|||
| return hook.service.find({ query }, params).then(results => { | |||
| if (hook.method === 'get' && Array.isArray(results) && results.length === 1) { | |||
There was a problem hiding this comment.
This can still also be an Array (e.g. if pagination is disabled), so I think we need to handle both cases.
There was a problem hiding this comment.
Sorry, it's been so long and I'm not all that familiar with Feathers' internals - do you mean that both results can be an array as well as results.data? Does this need to be handled in both this case and the case on line #135?
There was a problem hiding this comment.
What I mean is that the result can be either a plain array or a pagination object.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the
hasRoleOrRestricthook failed to return data in the expected format when used on aService#getmethod due to incorrect handling of the result of the hook's internal call toService#find. asService#findreturns an object with a "data" property that is always an array, we can safely check the nested value and correctly determine if the pseudo-get method call was successful.any application code hacking around the issue by knowingly pulling the nested "data" prop from the result will now break.