-
Notifications
You must be signed in to change notification settings - Fork 99
move typescript refactor to repo branch #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fratzinger
merged 26 commits into
feathersjs-ecosystem:typescript
from
fratzinger:master
Apr 18, 2021
Merged
move typescript refactor to repo branch #163
fratzinger
merged 26 commits into
feathersjs-ecosystem:typescript
from
fratzinger:master
Apr 18, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- complete typing - update dependencies - semistandard -> eslint-typescript - start converting tests to typescript - ref #144
- identityChange had no 'field' property - tests fixes
- add passwordField to options - propper typing
- call seperate services from main service
- destructure create-data for better IDE support - move AuthenticationManagementService to seperate file
- completely move `passwordField` to options
- Base class with publish-prevention - `useSeparateServicePaths` option - use internal service.options instead of create({ action: 'options' }) - add tests for publish - add tests for `useSeparateServicePaths` - more typings
- export defaultOptions -> addVerification - path - rearrange useSeparateServices
- divide Service & configure functions - ensure options per Service - types: better types - chore: update dependencies - tests: add tests for separate services - tests: increase about-time to 600
- better typing (abstract _create with type) - sort actions alphabetically
- overview page - started services page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed with claustres we move the refactoring to its own branch