Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cb from create method #79

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Remove cb from create method #79

merged 2 commits into from
Nov 28, 2017

Conversation

lwhiteley
Copy link
Contributor

Summary

feathers 3 doesn't support cb param for create function. (Breaking change)
causes too many arguments error

no dependencies ive seen

@lwhiteley
remove cb for create methods
6478e38 
feathers 3 doesnt support the cb param for rest methods anymore

causes: too many arguments error
@lwhiteley
remove rogue comma
beae487
@eddyystop
Copy link
Collaborator

Thanks for this.

Those client-side cb should have been removed when the server-side was changed to promises. Good catch.

@eddyystop eddyystop merged commit 285c572 into feathersjs-ecosystem:master Nov 28, 2017
@eddyystop
Copy link
Collaborator

Published as 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwhiteley @eddyystop