Skip to content

Commit

Permalink
Add default parameters to hook-less service methods (#182)
Browse files Browse the repository at this point in the history
  • Loading branch information
daffl authored Dec 29, 2018
1 parent 2420dc7 commit dcb762f
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class Service extends AdapterService {
return q;
}

_find (params) {
_find (params = {}) {
const { filters, query, paginate } = this.filterQuery(params);
const q = params.knex ? params.knex.clone() : this.createQuery(params);

Expand Down Expand Up @@ -204,7 +204,7 @@ class Service extends AdapterService {
return executeQuery().then(page => page.data).catch(errorHandler);
}

_findOrGet (id, params) {
_findOrGet (id, params = {}) {
const findParams = Object.assign({}, params, {
paginate: false,
query: Object.assign({}, params.query)
Expand All @@ -219,7 +219,7 @@ class Service extends AdapterService {
return this._find(findParams);
}

_get (id, params) {
_get (id, params = {}) {
return this._findOrGet(id, params).then(data => {
if (data.length !== 1) {
throw new errors.NotFound(`No record found for id '${id}'`);
Expand All @@ -229,7 +229,7 @@ class Service extends AdapterService {
}).catch(errorHandler);
}

_create (data, params) {
_create (data, params = {}) {
if (Array.isArray(data)) {
return Promise.all(data.map(current => this._create(current, params)));
}
Expand All @@ -241,7 +241,7 @@ class Service extends AdapterService {
}).catch(errorHandler);
}

_patch (id, raw, params) {
_patch (id, raw, params = {}) {
// Do not allow to patch the id
const data = _.omit(raw, this.id);
// By default we will just query for the one id. For multi patch
Expand Down Expand Up @@ -273,7 +273,7 @@ class Service extends AdapterService {
}).catch(errorHandler);
}

_update (id, data, params) {
_update (id, data, params = {}) {
return this._get(id, params).then(oldData => {
const newObject = Object.keys(oldData).reduce((result, key) => {
if (key !== this.id) { // We don't want the id field to be changed
Expand All @@ -289,7 +289,7 @@ class Service extends AdapterService {
}).catch(errorHandler);
}

_remove (id, params) {
_remove (id, params = {}) {
return this._findOrGet(id, params).then(items => {
const { query } = this.filterQuery(params);
const q = this.db(params);
Expand Down

0 comments on commit dcb762f

Please sign in to comment.