Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mssql patch issue, closes #188 #189

Merged
merged 3 commits into from
Jan 26, 2019
Merged

Mssql patch issue, closes #188 #189

merged 3 commits into from
Jan 26, 2019

Conversation

jerfowler
Copy link
Contributor

Summary

Resolves issue #188

  • Only $select this.id once
  • Make sure to use table/schema prefixes where appropriate

@daffl
Copy link
Member

daffl commented Jan 26, 2019

Makes sense, thank you!

@daffl daffl merged commit f063f79 into feathersjs-ecosystem:master Jan 26, 2019
@daffl daffl mentioned this pull request Jan 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerfowler @daffl