Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose ERROR symbol from error-handler #193

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

betarabbit
Copy link
Contributor

Summary

(If you have not already please refer to the contributing guideline as described
here
)

  • Tell us about the problem your pull request is solving.
    Per Error handling paragraph in README, ERROR symbol should accessible by const { ERROR } = require('feathers-knex'), however it is not exposed as expected.

  • Are there any open issues that are related to this?
    No.

  • Is this PR dependent on PRs in other repos?
    Yes

If so, please mention them to keep the conversations linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.

If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.

Thanks for contributing to Feathers! ❤️

@daffl
Copy link
Member

daffl commented Feb 18, 2019

Thanks! I thought it was even tested but apparently error[undefined] works just fine.

@daffl daffl merged commit a718a75 into feathersjs-ecosystem:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants