Disambiguates find query after patch #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us about the problem your pull request is solving.
When modifying the
params.knex
query with a join that introduces an ambiguous primary key, PATCH requests will fail with an ambiguous column error:To fix, the table is specified in the Patch request (see code in MR)
Are there any open issues that are related to this?
Not really. There's this: #164
But it's stale and only related in that it concerns the same service method.
Is this PR dependent on PRs in other repos?
No