Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

upgrading to lodash 4 and only requiring individual functions. #18

Closed
wants to merge 3 commits into from

Conversation

ekryski
Copy link
Member

@ekryski ekryski commented Feb 24, 2016

Closes #17.

@@ -1,6 +1,8 @@
if(!global._babelPolyfill) { require('babel-polyfill'); }

import _ from 'lodash';
import { isEmpty, pick, extend, omit } from 'lodash';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is how it works unless Babel added Tree shaking. We'll probably have to do

import isEmpty from 'lodash/isempty';
import extend from 'lodash/extend';

etc. Or to make it much easier and not having to change the rest of the code:

const _ = {
  extend: require('lodash/extend'),
  isEmpty: require('lodash/is-empty')
}

@daffl
Copy link
Member

daffl commented Feb 25, 2016

I'm going to close this one in favour of #19

@daffl daffl closed this Feb 25, 2016
@ekryski ekryski deleted the remove-lodash branch February 25, 2016 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants