Use model instance in singular patch on postgres #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinofstars
changed the title
skinofstars
force-pushed
the
fix/instance-sequelize-hooks-on-singular-patch
branch
2 times, most recently
from
472494b to
23b66d0
Compare
skinofstars
force-pushed
the
fix/instance-sequelize-hooks-on-singular-patch
branch
from
23b66d0 to
9e4db30
Compare
skinofstars
changed the title
|
This add complexity and would probably introduce changes that break others code. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PATCH method uses Model class update. This means that sequelize instance hooks aren't fired (eg.
afterUpdate). It also means that the postgres schema option is lost.This checks if the lookup is a singular object, and if so uses the instance.
resolves #155