fix: Do not log as errors below a 500 response (#1256)

feathersjs · Apr 22, 2019 · 33fd0e4 · 33fd0e4
1 parent 3f0b1c3
commit 33fd0e4
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/errors/lib/error-handler.js b/packages/errors/lib/error-handler.js
@@ -23,9 +23,16 @@ module.exports = function (options = {}) {
   }
 
   return function (error, req, res, next) {
+    // Set the error code for HTTP processing semantics
+    error.code = !isNaN(parseInt(error.code, 10)) ? parseInt(error.code, 10) : 500;
+
     // Log the error if it didn't come from a service method call
     if (options.logger && typeof options.logger.error === 'function' && !res.hook) {
-      options.logger.error(error);
+      if (error.code >= 500) {
+        options.logger.error(error);
+      } else {
+        options.logger.info(error);
+      }
     }
 
     if (error.type !== 'FeathersError') {
@@ -39,7 +46,6 @@ module.exports = function (options = {}) {
       }
     }
 
-    error.code = !isNaN(parseInt(error.code, 10)) ? parseInt(error.code, 10) : 500;
     const formatter = {};
 
     // If the developer passed a custom function for ALL html errors