Add option to set the maxListeners (#61)

feathersjs · Aug 21, 2018 · 58f490b · 58f490b
1 parent 22be348
commit 58f490b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/packages/socketio/src/index.js b/packages/socketio/src/index.js
@@ -29,11 +29,6 @@ export default function (options, config) {
           });
         }
 
-        if (typeof config === 'function') {
-          debug('Calling SocketIO configuration function');
-          config.call(this, io);
-        }
-
         this._socketInfo = {
           method: 'emit',
           connection () {
@@ -52,6 +47,11 @@ export default function (options, config) {
         // So we set it to a higher number. 64 should be enough for everyone.
         this._socketInfo.connection().setMaxListeners(64);
 
+        if (typeof config === 'function') {
+          debug('Calling SocketIO configuration function');
+          config.call(this, io);
+        }
+
         return this._super.apply(this, arguments);
       }
     }, app);

diff --git a/packages/socketio/test/index.test.js b/packages/socketio/test/index.test.js
@@ -76,6 +76,18 @@ describe('feathers-socketio', () => {
     let srv = app.listen(8887).on('listening', () => srv.close(done));
   });
 
+  it('can set MaxListeners', done => {
+    let app = feathers()
+      .configure(socketio(function (io) {
+        io.sockets.setMaxListeners(100);
+      }));
+
+    let srv = app.listen(8987).on('listening', () => {
+      assert.equal(app.io.sockets.getMaxListeners(), 100);
+      srv.close(done);
+    });
+  });
+
   it('can set options (#12)', done => {
     let app = feathers()
       .configure(socketio({