fix(schema): Do not error for schemas without properties (#2519)

feathersjs · Jan 5, 2022 · 96fdb47 · 96fdb47
1 parent 478e046
commit 96fdb47
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/packages/schema/src/schema.ts b/packages/schema/src/schema.ts
@@ -12,19 +12,21 @@ export class Schema<S extends JSONSchemaDefinition> {
   ajv: Ajv;
   validate: AsyncValidateFunction<FromSchema<S>>;
   definition: JSONSchema6;
-  propertyNames: string[];
   readonly _type!: FromSchema<S>;
 
   constructor (definition: S, ajv: Ajv = AJV) {
     this.ajv = ajv;
     this.definition = definition as JSONSchema6;
-    this.propertyNames = Object.keys(this.definition.properties)
     this.validate = this.ajv.compile({
       $async: true,
       ...this.definition
     });
   }
 
+  get propertyNames () {
+    return Object.keys(this.definition.properties || {});
+  }
+
   extend <D extends JSONSchemaDefinition> (definition: D) {
     const def = definition as JSONSchema6;
     const extended = {

diff --git a/packages/schema/test/schema.test.ts b/packages/schema/test/schema.test.ts
@@ -205,4 +205,34 @@ describe('@feathersjs/schema/schema', () => {
       user: { email: 'hello@feathersjs.com', age: 42 }
     });
   });
+
+  it('works with oneOf properties (#2508)', async () => {
+    const oneOfSchema = schema({
+      $id: 'schemaA',
+      oneOf: [
+        {
+          type: 'object',
+          additionalProperties: false,
+          required: ['x'],
+          properties: {
+            x: { type:'number'}
+          }
+        },
+        {
+          type: 'object',
+          additionalProperties: false,
+          required: ['y'],
+          properties: {
+            y: { type:'number'}
+          }
+        }
+      ]
+    } as const);
+
+    const res = await oneOfSchema.validate({
+      x: '3'
+    });
+
+    assert.deepStrictEqual(res, { x: 3 });
+  });
 });