Allow data to be an array (#75)

feathersjs · Aug 21, 2018 · a172d78 · a172d78
1 parent a1f1536
commit a172d78
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/errors/src/index.js b/packages/errors/src/index.js
@@ -27,7 +27,7 @@ function FeathersError (msg, name, code, className, data) {
     // NOTE(EK): To make sure that we are not messing
     // with immutable data, just make a copy.
     // https://github.com/feathersjs/feathers-errors/issues/19
-    newData = Object.assign({}, data);
+    newData = JSON.parse(JSON.stringify(data));
 
     if (newData.errors) {
       errors = newData.errors;

diff --git a/packages/errors/test/index.test.js b/packages/errors/test/index.test.js
@@ -286,5 +286,19 @@ describe('feathers-errors', () => {
       assert.equal(error.data.errors, undefined);
       assert.deepEqual(error.data, {foo: 'bar'});
     });
+
+    it('allows arrays as data', () => {
+      var data = [
+        {
+          hello: 'world'
+        }
+      ];
+      data.errors = 'Invalid input';
+
+      var error = new errors.GeneralError('Custom Error', data);
+      assert.equal(error.data.errors, undefined);
+      assert.ok(Array.isArray(error.data));
+      assert.deepEqual(error.data, [{hello: 'world'}]);
+    });
   });
 });